Skip to content

fix(controller): pre/post analysis support on blue green with autopromotion off. Fixes #4503 #4540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
nstires-ctgx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(controller): pre/post analysis support on blue green with autopromotion off. Fixes #4503 #4540

nstires-ctgx wants to merge 1 commit into from

Conversation

@nstires-ctgx
Copy link

@nstires-ctgx nstires-ctgx commented Nov 13, 2025 •
edited
Loading

Fixes #4503

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@codecov
Copy link

codecov bot commented Nov 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.40%. Comparing base (7518bde) to head (d80e8a5).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4540      +/-   ##
==========================================
+ Coverage   84.36%   84.40%   +0.03%     
==========================================
  Files         164      164              
  Lines       18841    18850       +9     
==========================================
+ Hits        15896    15911      +15     
+ Misses       2079     2077       -2     
+ Partials      866      862       -4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025 •
edited
Loading

Published E2E Test Results

  4 files    4 suites   3h 26m 58s ⏱️
117 tests 108 ✅  7 💤 2 ❌
472 runs  440 ✅ 28 💤 4 ❌

For more details on these failures, see this check.

Results for commit d80e8a5.

♻️ This comment has been updated with latest results.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 13, 2025 •
edited
Loading

Published Unit Test Results

2 373 tests   2 373 ✅  3m 3s ⏱️
  129 suites      0 💤
    1 files        0 ❌

Results for commit d80e8a5.

♻️ This comment has been updated with latest results.

todaywasawesome
todaywasawesome suggested changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why this wouldn't be in the CheckPodSpecChange function. It doesn't make sense to move the logic here.

@nstires-ctgx nstires-ctgx force-pushed the master branch 2 times, most recently from 0fff2f0 to 56cacab Compare November 25, 2025 18:57
@nstires-ctgx
Copy link
Author

nstires-ctgx commented Nov 26, 2025

I'm not sure why this wouldn't be in the CheckPodSpecChange function. It doesn't make sense to move the logic here.

This a bit better?

@nstires-ctgx
Return PR contents
d80e8a5 
Signed-off-by: Nick Stires <[email protected]>
@nstires-ctgx nstires-ctgx reopened this Dec 11, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2025

Please retry analysis of this Pull-Request directly on SonarQube Cloud

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zachaller zachaller Awaiting requested review from zachaller

1 more reviewer

@todaywasawesome todaywasawesome todaywasawesome requested changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

@kostis-codefresh kostis-codefresh

Labels

cherry-pick/release-1.9

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BlueGreen rollout with workloadRef ignores autoPromotionEnabled=false and pre/post promotion analysis

4 participants

@nstires-ctgx @todaywasawesome @zachaller @kostis-codefresh